Refactoring with scripts and stream commands help#335
Conversation
…r commands enums.
camierjs
left a comment
There was a problem hiding this comment.
Works great!
Tried down to the emscriptem & JS: looks good!
|
@najlkin, can you resolve the conflicts? |
|
There was just the patch #343 , which is not needed here as the data structure is redesigned here, so just an empty commit 😉 . |
|
Mention in |
|
@justinlaughlin and @v-dobrev -- do you want to take a look? |
|
ping: @justinlaughlin and @v-dobrev -- do you want to take a look? |
|
This is nice @najlkin. I think it would be nice if we had at least one or two small examples of glvis scripts; besides looking at source code, it is difficult to know that this option even exists. There is one small mention of it in the README but without explanation. My only reference a glvis script is a file I received on slack over a year ago 🙃. Regardless, this is a massive improvement to the internal logic! |
|
@justinlaughlin , that is why I have done this 🙂 , there is the complete list of commands on the website, which can be updated with every release thanks to this PR 😉 . |
|
@najlkin can you please resolve the conflicts? |
|
@tzanio , resolved ✔️ |
|
If we don't hear objections we are merging it tomorrow (1/27). |
Refactored the code base, separating scripts handling and introducing a help for script commands (which can be placed on the website too). At the moment it is:
Similarly, handling of stream commands has been refactored, offering the following help:
🌟 Besides there are multiple other improvements:
Windowstructure bundling (some of) the shared objects, eliminating the global state. This is a lightweight version of Refactoring to remove global state #170 .GetAppWindow()(a global function for obtaining thread-localSdlWindow)GLVisInitVis()anddisplay()inaux_js.cpp.StreamReader) and improvedDataState, so all data types can be animated 🎞️ .✔️ Tests: